Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuring-the-ip-address-using-the-virtual-machine-console.md #208

Merged
merged 4 commits into from
Oct 10, 2020

Conversation

casals
Copy link
Contributor

@casals casals commented Oct 7, 2020

Why:

Fixes #156 (partially - PR 1 of 2)

What's being changed:

Added a Note box at the end of the page to make it clear that we do not support multiple network adapters on GHES.

Additional information

I referenced GHES with the variable defined by data/variables/product/prodname_ghe_server . If this is not the correct product variable to use in this case, please reference the correct one as a required change to this PR.

Check off the following:

@@ -14,3 +14,10 @@ versions:
4. Configure options for the protocol you chose.
![Menu with IP protocol options](/assets/images/enterprise/network-configuration/network-settings-selection.png)
{% data reusables.enterprise_installation.vm-console-done %}

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casals Could you update this to use the callouts described in the content style guide and move it to the top of the procedural? That way users will have all of the information before they start working through the steps. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Fair warning - I inserted quite a few notes in yesterday's PRs, so when you come across them again could you please just tag me + "callout" or something similar? I'll adjust all of them. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - whenever I used notes at the beginning of their related context I labeled them as "Before you start", IIRC - could you please tag me on these as well? Consistency > ALL. :) Thanks!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 8, 2020
Moved "Notes" section to the top of the procedural
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @casals! I'll get it merged once things are green 🍏

@janiceilene janiceilene merged commit ca09b99 into github:main Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHES - Clarify that we do not support multiple network adapters
2 participants